feat: custom stylesheets #1122
Merged
feat: custom stylesheets #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandefreitas
force-pushed
the
develop
branch
2 times, most recently
from
109c0af to
bb3eb8f
Compare
The example file is no longer necessary because the real file can be generated with bootstrap.py. Additionally, bootstrap.py generates user presets without extra noise and unused presets.
alandefreitas
force-pushed
the
develop
branch
from
bb3eb8f to
f0e157a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1122 +/- ##
===============================
===============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the presentation quality of the generated HTML output by fixing the two issues that have been showing up the most in recent discussions:
We’ve recently talked a lot internally about the demos not looking as polished as the project deserves (especially around HTML styling/output) and these two were the biggest offenders.
Review notes
This PR touches a lot of files, but most of the churn is not core logic:
The actual implementation is much smaller and is basically in the last two commits.
Even in those last two commits, the important part to focus on is:
The rest is still mostly test fixtures/expected results.